Ticket #4006 (reopened enhancement)

Opened 3 years ago

Last modified 2 years ago

The triangles algorithm uses an extra array that is unneeded

Reported by: gemacke Owned by: gemacke
Priority: normal Milestone: 1.2
Version: 1.0 Severity: normal
Keywords: Cc:

Description

The triangles algorithm currently creates two arrays to calculate the accumulation array of the work to be done: work and accum_work. This was presumably done because there were problems getting parallelization to happen if the the work array were not precalculated. However, it can be done in a single loop without the work array. This will reduce memory usage from 2n + 1 to n + 1 for this step.

Change History

comment:1 Changed 3 years ago by gemacke

  • Status changed from new to accepted

comment:2 Changed 3 years ago by gemacke

  • Status changed from accepted to closed
  • Resolution set to fixed

Fixed in r3308.

comment:3 Changed 3 years ago by gemacke

  • Status changed from closed to reopened
  • Resolution fixed deleted

Backed out the change for this in r3309. Turns out without this array, a compiler bug happens that skews the results. Jon is writing up a bug report to send to Cray about this. For now, I will reopen this bug.

comment:4 Changed 3 years ago by gemacke

  • Version changed from 1.1 to 1.0
  • Milestone set to 1.1

comment:5 Changed 3 years ago by gemacke

  • component Eldorado deleted

comment:6 Changed 2 years ago by gemacke

  • Milestone changed from 1.1 to 1.2
Note: See TracTickets for help on using tickets.