Ticket #3903 (closed defect: fixed)
generates duplicate Message-IDs for notifications
|Reported by:||sascha-web-software.sandia.gov@…||Owned by:||jdsiiro|
The reason for this is that TicketNotifyEmail.get_message_id() creates predictable Message-IDs, with only self.ticket.id and self.modtime distinguishing messages for different tickets resp. different comments on the same ticket. For all moderation messages self.modtime stays at the default value of 0; for new tickets waiting for moderation even self.ticket.id gets set to 0. So most notification emails sent by TracTicketModerator? have the same Message-Id, causing threading to be broken and some MUAs (e.g. sup) to even ignore any but the very first message as duplicates.
Maybe ModeratorNofityEmail (typo?) should override TicketNotifyEmail.get_message_id() and include additional fields in the hash value? Even a random value would do since moderation notifications don't need to get threaded (thus no need for calculating previously used Message-Id values).