Comments you submit will be routed for moderation. If you have an account, please log in first.

Ticket #3903 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

generates duplicate Message-IDs for notifications

Reported by:… Owned by: jdsiiro
Priority: major Milestone:
Component: TracTicketModerator Version: TracTicketModerator 0.6.2
Keywords: Cc:


TracTicketModerator? causes different notification emails with the same Message-ID to be sent. See the downstream bug  SL#2526 for copies of two messages where this happened.

The reason for this is that  TicketNotifyEmail.get_message_id() creates predictable Message-IDs, with only and self.modtime distinguishing messages for different tickets resp. different comments on the same ticket. For all moderation messages self.modtime stays at the  default value of 0; for new tickets waiting for moderation even gets set to 0. So most notification emails sent by TracTicketModerator? have the same Message-Id, causing threading to be broken and some MUAs (e.g.  sup) to even ignore any but the very first message as duplicates.

Maybe ModeratorNofityEmail (typo?) should override TicketNotifyEmail.get_message_id() and include additional fields in the hash value? Even a random value would do since moderation notifications don't need to get threaded (thus no need for calculating previously used Message-Id values).


0001-ModeratorNofityEmail-ensure-Message-IDs-are-unique.patch Download (2.0 KB) - added by… 7 years ago.
[PATCH] ModeratorNofityEmail?: ensure Message-IDs are unique

Change History

Changed 7 years ago by…

[PATCH] ModeratorNofityEmail?: ensure Message-IDs are unique

comment:1 Changed 7 years ago by jdsiiro

Referenced in changeset [2689]:

Override the default notification system method for generating the moderation e-mail Message-ID. The new approach generates a random Message-ID, which for all intents and purposes is unique. Fixes #3903.

comment:2 Changed 7 years ago by jdsiiro

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r2689.


Add a comment

Modify Ticket

Change Properties
<Author field>
as closed
The resolution will be deleted. Next status will be 'reopened'

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.